Allow to disable new line padding on paste for specific elements #17068
Conversation
|
Why this works on our merge fields and doesn't on custom written placeholders? Maybe we lack some abstraction? |
|
@Witoso From what I can see merge tags use @Dumluregn Do you know why this happens? Can we use |
There was a problem hiding this comment.
The newLinePadding() helper is unfortunately based on the assumption that the view ContainerElement is a block element and this is not a valid assumption. Maybe we could use DomConverter#blockElements as a list of view elements which should be considered a block?
I'd suggest not adding another custom property.
|
@niegowski Isn't it breaking change? I'm not sure what should API look like, because we have plenty of downcasts which do not determine which view element is a block element and which not. ahh, now I get it. I was thinking that we want to add new |
Mati365
force-pushed
the
ck/16923
branch
3 times, most recently
from
4d2e0fa
to
66bf853
Compare
|
@niegowski Looks like it works 🎉 |
…mpty lines before and after widget text.
|
Please, let's plan this BC together for some specific release. Don't merge. |
Suggested merge commit message (convention)
Fix (clipboard): Pasting an inline widget as plain text no longer inserts additional empty lines before and after pasted widget. Closes #17052
MAJOR BREAKING CHANGE (clipboard): Pasting an inline widget as plain text no longer inserts additional empty lines before and after pasted widget.
Additional information
Not sure if proposed solution is the correct one. How can we determine model element schema attributes based on view elements from clipboard content?
Before:
before-new-line-fix-2024-09-10_08.51.47.mp4
After:
after-new-line-fix-2024-09-10_08.50.11.mp4